setup: Simplify build of abi3 wheels and add tests#3433
Merged
bdarnell merged 3 commits intotornadoweb:masterfrom Oct 24, 2024
Merged
setup: Simplify build of abi3 wheels and add tests#3433bdarnell merged 3 commits intotornadoweb:masterfrom
bdarnell merged 3 commits intotornadoweb:masterfrom
Conversation
macos-12 is leaving support soon; macos-15 is currently the latest version. See actions/runner-images#10721
This is no longer necessary in recent versions of setuptools (and we now check that abi3 is used properly in official releases). The bdist_wheel implementation is being moved from the wheel package into setuptools so overriding it will stop working in the future. Follows the example of joerick/python-abi3-package-sample#30 Replaces tornadoweb#3425
|
I can confirm that this works with setuptools main branch. Deleting complexity is better than making it more complex 🤣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our hacky override of the
bdist_wheelcommand is no longer necessary and will stop working in future versions of setuptools. Remove it, and add tests with theabi3auditpackage to ensure that our official releases remain abi3-compatible.This PR replaces #3425 which fixed the future-setuptools compatibility but left the override in place.